View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002807DCP-o-maticBugspublic2024-05-12 16:372024-06-24 22:02
Reportercarl Assigned Tocarl  
PriorityhighSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version2.17.19 
Summary0002807: Y offset control does not work the same for all subtitle types
Description

When you have an SRT subtitle and want to use them as “open subtitles” the Y-Offset moves the subtitle down when you decrease it. If you do the same with subtitles from an MKV file, it’s the exact opposite. I think the SRT way is the correct and the more intuitive way.

Tagsemail
Branch2807-ysubs
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2024-05-13 00:21

administrator   ~0006405 

index c03cb97a5..408f0dd4c 100644
--- a/src/lib/player.cc
+++ b/src/lib/player.cc
@@ -1242,7 +1242,7 @@ Player::bitmap_text_start (weak_ptr<Piece> weak_piece, weak_ptr<const TextConten
        {
                /* Apply content's subtitle offsets */
                sub.rectangle.x += content->x_offset ();
-               sub.rectangle.y += content->y_offset ();
+               sub.rectangle.y -= content->y_offset ();

                /* Apply a corrective translation to keep the subtitle centred after the scale that is coming up */
                sub.rectangle.x -= sub.rectangle.width * ((content->x_scale() - 1) / 2);

carl

2024-05-13 00:21

administrator   ~0006406

seems like enough but breaks existing projects of course

carl

2024-06-24 22:02

administrator   ~0006454

b11083f68b7971556e5003093b44c1835407b315

Issue History

Date Modified Username Field Change
2024-05-12 16:37 carl New Issue
2024-05-12 16:37 carl Tag Attached: email
2024-05-12 16:37 carl Assigned To => carl
2024-05-12 16:37 carl Status new => acknowledged
2024-05-12 23:23 carl Status acknowledged => confirmed
2024-05-12 23:24 carl Priority normal => high
2024-05-12 23:24 carl Estimated work required => Undecided
2024-05-13 00:21 carl Note Added: 0006405
2024-05-13 00:21 carl Note Added: 0006406
2024-06-06 21:27 carl Target Version => 2.17.19
2024-06-18 17:02 carl Branch => 2807-ysubs
2024-06-18 17:02 carl Status confirmed => in progress
2024-06-24 22:02 carl Status in progress => resolved
2024-06-24 22:02 carl Resolution open => fixed
2024-06-24 22:02 carl Note Added: 0006454