View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002571DCP-o-maticBugspublic2023-06-22 14:402025-10-29 11:01
Reporterboxerab Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0002571: Code "bug" : calling virtual method in constructor
Description

I've run cppcheck on the code - lots of interesting warnings. One such is a virtual call inside the Controls constructor

    _timer.Start (80, wxTIMER_CONTINUOUS);

    set_film(viewer.film());

    setup_sensitivity ();

set_film is virtual.

TagsNo tags attached.
Branch
Estimated weeks required
Estimated work required

Activities

boxerab

2023-06-22 14:41

reporter   ~0005776

Forgot to mention: this is in dcpomatic project.

carl

2023-06-22 16:45

administrator   ~0005784

Thanks, fixed in c9c1b5e7edce7f7fd531b448323c3b2b2f5c7e65

Issue History

Date Modified Username Field Change
2023-06-22 14:40 boxerab New Issue
2023-06-22 14:41 boxerab Note Added: 0005776
2023-06-22 16:45 carl Assigned To => carl
2023-06-22 16:45 carl Status new => resolved
2023-06-22 16:45 carl Resolution open => fixed
2023-06-22 16:45 carl Note Added: 0005784
2025-10-29 11:01 carl Status resolved => closed