View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002271DCP-o-maticBugspublic2022-06-07 23:012023-09-01 21:52
Reportercarl Assigned Tocarl  
PriorityimmediateSeverityblockReproducibilityalways
Status closedResolutionfixed 
Target Version2.16.14 
Summary0002271: Making a DCP from a project containing subs made < 2.16.14 fails as the Font stuff isn't written correctly
Description

... only set up during examination.

TagsNo tags attached.
Branch2271-fix-font-ids
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2022-06-08 23:48

administrator   ~0005087

e.g. with a srt, the metadata used to contaim

<Font>
  <Id>font</Id>
<Font>

after re-examination it has

<Font>
  <Id></Id>
<Font>

because this font is now identified by an empty ID (because there is no Font ID in the .srt).

The old metadata does not work because FontIdMap::get() fails in ReelWriter::write() around 935. Here we are trying to get the ID (from our re-written list) that corresponds to a shared_ptr<Font>. However that shared_ptr<Font> will be null because when the sub was emitted in TextDecoder::emit_plain_start() the font with the ID "" was not found (so a nullptr) is used.

Re-writing font to "" in Fonts for StringTextFileContent would help with .srt inputs. I think .ssa inputs are more of a problem.

Maybe we should just force a re-exam of StringTextFileContent.

Basically the IDs use in the actual file have to correspond to the IDs in the <Font> tags in the metadata.

carl

2022-06-10 22:12

administrator   ~0005092

14e02ad2f79bdc6fbc320ec7b9282b5faabdb825

Issue History

Date Modified Username Field Change
2022-06-07 23:01 carl New Issue
2022-06-07 23:01 carl Assigned To => carl
2022-06-07 23:01 carl Status new => confirmed
2022-06-08 23:48 carl Note Added: 0005087
2022-06-09 20:15 carl Branch => 2271-fix-font-ids
2022-06-09 20:15 carl Estimated work required => Undecided
2022-06-10 21:27 carl Status confirmed => in progress
2022-06-10 22:12 carl Status in progress => resolved
2022-06-10 22:12 carl Resolution open => fixed
2022-06-10 22:12 carl Note Added: 0005092
2023-09-01 21:52 carl Status resolved => closed