View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002226DCP-o-maticFeaturespublic2022-04-05 23:442024-04-17 08:16
Reportercarl Assigned Tocarl  
PrioritynormalSeverityfeatureReproducibilityN/A
Status acknowledgedResolutionfixed 
Target Version2.18.x 
Summary0002226: Add video waveform dialog to player
Description

[]

Tagsplayer
Branch2226-add-video-waveform-to-player
Estimated weeks required
Estimated work requiredUndecided

Relationships

has duplicate 0002490 acknowledgedcarl Make video waveform display available in DCP-o-matic player as well 

Activities

carl

2022-08-04 21:17

administrator   ~0005156

This is done in a stash on shankly but it shows up bugs in the waveform view, as it uses the scaled image (scaled for playback) rather than the full DCP frame. Fixing this seems to suggest we want to change how sizes are stored in PlayerVideo - see adjust-sizing.

carl

2022-08-04 22:54

administrator   ~0005157

The adjust-sizing branch tried to remove the knowledge of the output frame size from PlayerVideo (and hence, ideally, from Player) but this is not possible because Player needs to know the output size in order to scale subtitles correctly. I think this is difficult to get around without storing subtitles in some output-resolution-independent way.

carl

2022-08-04 23:47

administrator   ~0005158

Branch seems ok, just need to run tests/merge.

carl

2022-08-11 22:12

administrator   ~0005166

Last edited: 2022-08-11 22:21

Waveform is totally wrong with this branch for things like DCP-o-matic_2K_test.mov from the recent forum post (and Arrietty). Need to clarify what the video waveform should actually show - presumably what would happen if this content were made into a DCP?

Issue History

Date Modified Username Field Change
2022-04-05 23:44 carl New Issue
2022-04-05 23:44 carl Assigned To => carl
2022-04-05 23:44 carl Status new => acknowledged
2022-08-04 21:17 carl Note Added: 0005156
2022-08-04 21:17 carl Status acknowledged => in progress
2022-08-04 22:54 carl Note Added: 0005157
2022-08-04 23:15 carl Branch => 2226-add-video-waveform-to-player
2022-08-04 23:15 carl Estimated work required => Undecided
2022-08-04 23:47 carl Note Added: 0005158
2022-08-04 23:47 carl Target Version 2.16.x => 2.16.20
2022-08-11 21:47 carl Status in progress => resolved
2022-08-11 21:47 carl Resolution open => fixed
2022-08-11 22:11 carl Status resolved => in progress
2022-08-11 22:12 carl Note Added: 0005166
2022-08-11 22:13 carl Note Edited: 0005166
2022-08-11 22:21 carl Note Edited: 0005166
2022-08-14 21:05 carl Target Version 2.16.20 => 2.16.21
2022-08-16 22:03 carl Target Version 2.16.21 => 2.16.22
2022-08-28 23:37 carl Target Version 2.16.22 => 2.16.23
2022-09-03 21:03 carl Target Version 2.16.23 => 2.16.24
2022-09-04 13:16 carl Target Version 2.16.24 => 2.16.25
2022-09-11 08:37 carl Target Version 2.16.25 => 2.16.26
2022-09-18 20:55 carl Target Version 2.16.26 => 2.16.27
2022-09-24 21:55 carl Target Version 2.16.27 => 2.16.28
2022-09-28 23:48 carl Priority normal => high
2022-10-05 17:48 carl Target Version 2.16.28 => 2.16.30
2022-10-12 11:53 carl Target Version 2.16.30 => 2.16.31
2022-10-19 19:47 carl Target Version 2.16.31 => 2.16.32
2022-10-26 19:07 carl Target Version 2.16.32 => 2.16.x
2023-03-17 13:52 carl Relationship added has duplicate 0002490
2023-07-02 22:26 carl Status in progress => acknowledged
2023-09-14 23:46 carl Target Version 2.16.x => 2.18.0
2024-01-03 11:53 carl Severity minor => feature
2024-01-13 21:43 carl Priority high => normal
2024-01-13 21:43 carl Target Version 2.18.0 => 2.18.x
2024-02-16 09:00 carl Tag Attached: player