View Bug Details

IDProjectCategoryView StatusLast Update
0002600DCP-o-maticBugspublic2023-10-15 08:14
Reporteroverlookmotel Assigned Tocarl  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionduplicate 
PlatformMacOSOS XOS Version10.14
Product Version2.16.60 
Target Version2.16.66 
Summary0002600: Cannot open VF DCP with closed captions referencing OV DCP with open subtitles
Description

I have 2 DCPs:

  1. OV DCP with soft open subtitles.
  2. VF DCP referencing OV DCP, and adding closed captions

(the VF DCP is the one I tricked DCP-o-matic into making, described in 0002559)

DCP-o-matic is unable to open this VF DCP. Steps:

  • Create new DOM project
  • "Add DCP" and select VF DCP
  • DCP-o-matic shows "NEEDS OV" (correctly)
  • "Add OV" and select OV DCP

DOM gives an error Error: Programming error at ../src/lib/text_content.cc:449.

It may be that the VF DCP I've made is faulty in some way, but as far as I can see, there's nothing apparently wrong with it. It passes dcp_inspect validation.

Steps To Reproduce

Carl I'll email you a repro case.

Tagsgit-bug
Branch2600-vf
Estimated weeks required
Estimated work requiredUndecided

Relationships

duplicate of 0002627 resolvedcarl PE at text_content.cc:452 when loading SMPTE_TST-B1PB2P_S_EN-EN-CCAP_5171-HI-VI_2K_ISDCF_20151123_DPPT_SMPTE_combo 

Activities

carl

2023-08-28 23:05

administrator   ~0005905

Last edited: 2023-08-28 23:06

  • OV gets made, subs have a font with ID font.
  • id_for_font_in_reel renames this to 0_font when the OV is "played" for the VF
  • VF adds CCAPS which start with an empty font ID.
  • Write::write sees 0_font and an empty ID, changes the empty one to font.
  • Now the OV+VF both have text with a font called font.
  • TextContent::add_font can't cope with this, and add_fonts_from_examiner doesn't try to disambiguate because it assumes one font per reel.

carl

2023-08-28 23:09

administrator   ~0005906

Possible answers:

  • don't disambiguate referred DCP fonts, as it will have no effect on the referred DCP; could be tricky as the disambiguation is done on examination
  • if it's OK to have subs + ccaps in the same reel with the same font ID, make TextContent cope with this, or make add_fonts_from_examiner disambiguate better (understanding that a reel can have multiple fonts associate with it).

carl

2023-10-10 22:05

administrator   ~0006002

SMPTE example has subs + ccaps in the same reel with the same font ID.

carl

2023-10-15 08:13

administrator   ~0006016

3c802dd6d1451c2c8a7e188f8379738d72e907eb

Bug History

Date Modified Username Field Change
2023-08-18 23:41 overlookmotel New Bug
2023-08-20 21:14 carl Assigned To => carl
2023-08-20 21:14 carl Status new => acknowledged
2023-08-20 21:14 carl Target Version => 2.16.62
2023-08-20 21:14 carl Estimated work required => Undecided
2023-08-20 21:14 carl Tag Attached: git-bug
2023-08-20 21:18 carl Target Version 2.16.62 => 2.16.63
2023-08-28 19:58 carl Status acknowledged => confirmed
2023-08-28 22:09 carl Branch => 2600-vf
2023-08-28 23:05 carl Note Added: 0005905
2023-08-28 23:05 carl Note Edited: 0005905
2023-08-28 23:06 carl Note Edited: 0005905
2023-08-28 23:09 carl Note Added: 0005906
2023-08-31 23:11 carl Target Version 2.16.63 => 2.16.64
2023-09-13 22:34 carl Target Version 2.16.64 => 2.16.65
2023-09-21 00:08 carl Target Version 2.16.65 => 2.16.66
2023-10-09 23:12 carl Relationship added duplicate of 0002627
2023-10-10 22:05 carl Note Added: 0006002
2023-10-15 08:13 carl Note Added: 0006016
2023-10-15 08:14 carl Status confirmed => resolved
2023-10-15 08:14 carl Resolution open => duplicate