View Bug Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002389DCP-o-maticBugspublic2022-12-11 13:502023-09-01 21:53
Reportercarl Assigned Tocarl  
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version2.16.45 
Summary0002389: Fix subtitle vertical positioning SNAFU
Description
  • I guess make the player respect the standard of the subtitle file (which it should do for free) but also allow the uncertainty rectangle, and maybe force 2010/2014 in the renderer
  • maybe add SMPTE 2010 output by some hidden option
  • fix SMPTE 2010 output to take ascenders/descenders into account

Done

  • test: check vpos for interop/smpte20{10,14} input and output
  • add option (it's not an option --- it's always there) to display the uncertainty of the projector rendering with 2010/2014
  • use bottom as the reference for SRT etc.
  • support SMPTE 2014 in render_text as a copy of Interop (extend valign_standard I guess)
  • use SMPTE 2014 to pass un-placed subs through, to fix the bug mentioned in the comment below
  • default to SMPTE 2014 output
TagsNo tags attached.
Branch2389-vpos [also in libdcp]
Estimated weeks required
Estimated work requiredUndecided

Activities

carl

2022-12-11 19:05

administrator   ~0005359

https://dcpomatic.com/forum/viewtopic.php?p=9725

carl

2022-12-11 23:12

administrator   ~0005360

Last edited: 2023-01-20 21:05

This exposes a bug in the placement of (e.g.) SRT subs. If you have two lines, the difference in vpos between them is always the same (called multiplier in text_decoder.cc)
This is wrong for the SMPTE 2010 case because the required spacing depends on the text metrics. I suspect the code to convert between interop and SMPTE (2010) is also wrong
here as it seems to assume that all font lines have descenders.

carl

2022-12-23 22:57

administrator   ~0005396

Perhaps the "uncertainty rectangle" should be included in what's displayed with the "show subtitle area" checkbox in the subtitle tab.

carl

2022-12-23 23:17

administrator   ~0005397

So some changes could go into AnalyseSubtitlesJob::analyse

carl

2023-02-18 23:41

administrator   ~0005509

Made a build and posted on the forum about it.

carl

2023-02-27 14:02

administrator   ~0005540

e163200eaaf65c63d5105949432140f4084de037

Bug History

Date Modified Username Field Change
2022-12-11 13:50 carl New Bug
2022-12-11 13:50 carl Assigned To => carl
2022-12-11 13:50 carl Status new => acknowledged
2022-12-11 13:50 carl Description Updated
2022-12-11 13:50 carl Estimated work required => Undecided
2022-12-11 19:05 carl Note Added: 0005359
2022-12-11 21:28 carl Branch => 2389-vpos [also in libdcp]
2022-12-11 21:28 carl Status acknowledged => in progress
2022-12-11 23:12 carl Note Added: 0005360
2022-12-11 23:13 carl Description Updated
2022-12-21 23:41 carl Target Version 2.16.36 => 2.16.37
2022-12-23 14:48 carl Target Version 2.16.37 => 2.16.38
2022-12-23 21:06 carl Description Updated
2022-12-23 22:57 carl Note Added: 0005396
2022-12-23 23:17 carl Note Added: 0005397
2023-01-07 23:46 carl Target Version 2.16.38 => 2.16.41
2023-01-20 21:05 carl Note Edited: 0005360
2023-01-20 21:06 carl Description Updated
2023-01-20 21:10 carl Description Updated
2023-01-20 21:16 carl Description Updated
2023-01-21 21:31 carl Description Updated
2023-01-21 21:34 carl Description Updated
2023-01-21 22:42 carl Description Updated
2023-01-21 22:42 carl Description Updated
2023-01-23 22:42 carl Description Updated
2023-01-24 11:37 carl Target Version 2.16.41 => 2.16.42
2023-02-02 00:12 carl Target Version 2.16.42 => 2.16.43
2023-02-16 18:53 carl Target Version 2.16.43 => 2.16.44
2023-02-18 23:41 carl Status in progress => feedback
2023-02-18 23:41 carl Note Added: 0005509
2023-02-18 23:54 carl Target Version 2.16.44 => 2.16.45
2023-02-27 14:02 carl Status feedback => resolved
2023-02-27 14:02 carl Resolution open => fixed
2023-02-27 14:02 carl Note Added: 0005540
2023-09-01 21:53 carl Status resolved => closed