0001784: Fix -Wsign-compare bugs that mingw's compiler emits

ID	Project	Category	View Status	Date Submitted	Last Update

0001784	DCP-o-matic	Bugs	public	2020-07-20 19:14	2023-09-01 21:48

Reporter	carl	Assigned To	carl
Priority	immediate	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	won't fix
Target Version	2.16.0

Summary	0001784: Fix -Wsign-compare bugs that mingw's compiler emits
Description	[]
Tags	No tags attached.

Branch
Estimated weeks required
Estimated work required	Undecided

carl 2020-07-24 22:19 administrator ~0003870	`signed-unsigned` branch

carl 2020-07-25 22:09 administrator ~0003871	This just seems to be more trouble than it's worth; doing a few fixes suggests that the majority of the warnings are due to signed values hitting up against std::vector::size() or indices for vectors. The best you can do seems to be a bunch of `static_cast<size_t>` with `assert`s to check that values are `>0` first. Such asserts could be added (and `-Wsign-compare` is a useful way to find where they might be needed). Things might be neater with an extended / new `vector` type which use signed indices and `size().`

Date Modified	Username	Field	Change
2020-07-20 19:14	carl	New Bug
2020-07-20 19:14	carl	Status	new => acknowledged
2020-07-20 19:14	carl	Estimated work required	=> Undecided
2020-07-24 22:19	carl	Note Added: 0003870
2020-07-25 22:09	carl	Assigned To	=> carl
2020-07-25 22:09	carl	Status	acknowledged => resolved
2020-07-25 22:09	carl	Resolution	open => won't fix
2020-07-25 22:09	carl	Note Added: 0003871
2023-09-01 21:48	carl	Status	resolved => closed